static on Private Methods

I have always wondered what this was about in a class where a public non-static method calls a private method.  Here is the example.

 public void CreateLocalResourceProvider(IContract contract)

        {

 

          …

          result = CreateDBProvider(String.Empty, contract);

          …

       }

 

private static IDBProvider CreateDBProvider(string a, IContract contract)

{

    …

 

}

 

After running enabling CodeAnalysis on my solution, I received a warning that the private method was not static  or that I needed to use the “this/me” keyword if appropriate.

 

Here is the help for this rule:

 

Methods that do not access instance data or call instance methods can be marked as static
(Shared in Visual Basic). After you mark the methods as static, the compiler will emit non-virtual
call sites to these members. Emitting non-virtual call sites will prevent a check at runtime for
each call that ensures that the current object pointer is non-null. This can result in a
measurable performance gain for performance-sensitive code. In some cases, the failure to
access the current object instance represents a correctness issue.

 

So now I understand why to use a static private method.  The things you learn from code

analysis.

 

Technorati Tags: development, C#, tips